Skip to content

fix(giscus): initialize giscus script with correct theme #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

fix(giscus): initialize giscus script with correct theme #864

merged 1 commit into from
Oct 9, 2025

Conversation

santhosh-005
Copy link
Contributor

@santhosh-005 santhosh-005 commented Oct 9, 2025 •
edited
Loading

Description

Fixes the Giscus comments section theme mismatch during page load and hydration. Previously, Giscus would initialize in light mode even on dark-themed sites because the initial theme was read from useColorMode before hydration. This update ensures the correct theme is applied on first render and dynamically updates when the user toggles the site theme.

Fixes #858

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

  • Initialize Giscus script using localStorage or HTML data-theme to reflect the user’s actual theme on first load.
  • Ensures SSR-safe and efficient loading without re-injecting the script multiple times.

Dependencies

  • No new dependencies added.
  • Works with existing Docusaurus setup and @docusaurus/theme-common

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers and devices
  • My changes do not generate new console warnings or errors .
  • I ran npm run build and attached screenshot(s) in this PR.
  • This is already assigned Issue to me, not an unassigned issue.
image

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2025

@santhosh-005 is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@github-actions github-actions bot added hacktoberfest-accepted level 1 10 points recode this is label for leaderboard labels Oct 9, 2025
@sanjay-kv sanjay-kv moved this to In Progress in @recode-web Oct 9, 2025
@sanjay-kv sanjay-kv added this to the recode:launch 3.0 milestone Oct 9, 2025
@vercel Vercel
Copy link

vercel bot commented Oct 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Ready Ready Preview Comment Oct 9, 2025 7:30am

@sanjay-kv sanjay-kv merged commit a4a479a into recodehive:main Oct 9, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Oct 9, 2025
@santhosh-005 santhosh-005 mentioned this pull request Oct 9, 2025
Closed
4 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2025 •
edited
Loading

Synced data from Linked Issues

Labels:

  • level 1
  • recode
  • hacktoberfest-accepted

Assignees:

  • santhosh-005

Milestones:

  • recode:launch 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sanjay-kv sanjay-kv sanjay-kv approved these changes

Assignees

@santhosh-005 santhosh-005

Labels

hacktoberfest-accepted level 1 10 points recode this is label for leaderboard

Projects

@recode-web
Status: Done

Milestone

recode:launch 3.0

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Giscus comment box doesn’t switch to dark mode

2 participants

@santhosh-005 @sanjay-kv